Support external memory in CPU histogram building. #7372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @ShvetsKS |
|
@ShvetsKS Could you please take a look into this PR? We can set |
Port the rest. Comment. Start test. Debug. Remove. test. Format. Fix test..
trivialfis
force-pushed
the
external-mem-hist
branch
from
3067841
to
88fc335
Compare
|
@ShvetsKS friendly ping. |
|
I will merge this PR next week if there's no objection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #7214
The perf change for the complete PR is in #7214 (comment) . Might have some small overhead (within variance), but the benefit is hist/approx will be able to support both categorical data and external memory in the future.
SubtractionTrickfunction. The builder class can be completely removed, but I will keep the cleanup out of the scope.