Dispatch thrust versions and upgrade rmm. #7254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivialfis
force-pushed
the
upgrade-rmm
branch
from
3007cea
to
a2a72d2
Compare
trivialfis
force-pushed
the
upgrade-rmm
branch
from
f8fea4a
to
9dd9e00
Compare
trivialfis
commented
Sep 24, 2021
| @@ -112,6 +112,9 @@ endif (ENABLE_ALL_WARNINGS) | |||
| if (BUILD_STATIC_LIB AND (R_LIB OR JVM_BINDINGS)) | |||
| message(SEND_ERROR "Cannot build a static library libxgboost.a when R or JVM packages are enabled.") | |||
| endif (BUILD_STATIC_LIB AND (R_LIB OR JVM_BINDINGS)) | |||
| if (PLUGIN_RMM AND (NOT BUILD_WITH_CUDA_CUB)) | |||
There was a problem hiding this comment.
Disabled the cub submodule to simplify things.
hcho3
reviewed
Sep 24, 2021
Co-authored-by: Philip Hyunsu Cho <chohyu01@cs.washington.edu>
hcho3
approved these changes
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.