Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor external memory formats. #7089

Merged
merged 1 commit into from Jul 7, 2021
Merged

Conversation

trivialfis
Copy link
Member

@trivialfis trivialfis commented Jul 7, 2021

  • Save base_rowid.
  • Return write size.
  • Remove unused function.
  • Add tests.

Part of #7070 .

* Save base_rowid.
* Return write size.
* Remove unused function.
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2021

Codecov Report

Merging #7089 (9d723d2) into master (615ab2b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7089   +/-   ##
=======================================
  Coverage   81.61%   81.61%           
=======================================
  Files          13       13           
  Lines        3899     3899           
=======================================
  Hits         3182     3182           
  Misses        717      717           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 615ab2b...9d723d2. Read the comment docs.

@trivialfis trivialfis merged commit c766f14 into dmlc:master Jul 7, 2021
@trivialfis trivialfis deleted the page-format branch July 7, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants