Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support hessian in host sketch container. #7081

Merged
merged 6 commits into from Jul 8, 2021

Conversation

trivialfis
Copy link
Member

  • Implement some utilities for threads to reduce dependency on omp_get_max_threads.
  • Merge hessian with sample weights.

@trivialfis trivialfis mentioned this pull request Jul 6, 2021
67 tasks
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2021

Codecov Report

Merging #7081 (35a838a) into master (f937f51) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7081   +/-   ##
=======================================
  Coverage   81.61%   81.61%           
=======================================
  Files          13       13           
  Lines        3899     3899           
=======================================
  Hits         3182     3182           
  Misses        717      717           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f937f51...35a838a. Read the comment docs.

* Define a parallel for function that accepts schedule.
* Support hessian with group weights.
@trivialfis
Copy link
Member Author

This is part of refactoring the approx tree method. In the implementation of current approx the sample weight is ignored, but the impl in this PR multiples the sample weight with hessian.

src/common/quantile.cc Show resolved Hide resolved
@trivialfis trivialfis merged commit 77f6cf2 into dmlc:master Jul 8, 2021
@trivialfis trivialfis deleted the hessian-sketch branch July 8, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants