Support categorical data for dask functional interface and DQM. #7043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivialfis
changed the title
trivialfis
commented
Jun 16, 2021
trivialfis
commented
Jun 16, 2021
|
I think there is stalled cache in mgpu worker. |
|
@trivialfis I just cleared the cache. |
* Implement categorical data support for GPU GK-merge. * Add support for dask functional interface. * Add support for DQM.
RAMitchell
approved these changes
Jun 18, 2021
| }; | ||
| struct SketchUnique { | ||
| XGBOOST_DEVICE bool operator()(SketchEntry const& a, SketchEntry const& b) const { | ||
| return a.value - b.value == 0; |
There was a problem hiding this comment.
What is this comparator doing?
There was a problem hiding this comment.
See if they are equal.
There was a problem hiding this comment.
If memory is correct, I think that is not guaranteed to work: https://docs.oracle.com/cd/E19957-01/806-3568/ncg_goldberg.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #7042 .