[Roadmap] 1.3.2 Patch release

[trivialfis]

We are looking to release a patch release 1.3.2.

This issue will remain open until January 11, 2021.

@dmlc/xgboost-committer

Pull requests:

• [Breaking] Rename data to X in predict_proba. #6555 Fix compatibility with newer scikit-learn.
• Fix best_ntree_limit for multi-class. #6569 Fix wrong best_ntree_limit in multi-class.
• [CRAN] Major issues from CRAN check for most platforms. #6542 (comment) Support Solaris. #6578 Remove type check for solaris. #6606 Ensure that Rabit can be compiled on Solaris
• Fix best_ntree_limit for dart and gblinear. #6579 Fix best_ntree_limit for linear and dart.
• Remove duplicated DMatrix. #6592 Remove duplicated DMatrix.
• Fix evaluation result for XGBRanker. #6594 Fix evals_result in ranker.

[trivialfis]

@hcho3 All merged now.

[hcho3]

@trivialfis Great! Why don't you give a shot at making the patch release? Use #6543 as an example.

[trivialfis]

Thanks for the suggestion, let me do that tomorrow.

[trivialfis]

@hcho3 @hetong007 I created a release page. Next would be submitting packages to pip and cran.

[hetong007]

@trivialfis I uploaded this branch onto R-hub, and it still reports error: https://builder.r-hub.io/status/xgboost_1.3.2.1.tar.gz-f47cc590f1434dddb4c4b89cd02703dc

This error is from R-hub with platform Oracle Solaris 10, x86, 32 bit, R-release, Oracle Developer Studio 12.6. This matches the compiler of CRAN Solaris: https://cran.r-project.org/web/checks/check_flavors.html#r-patched-solaris-x86

[trivialfis]

Em .. failing to install

[hcho3]

The link shows success?

[trivialfis]

Looked a little bit closer:

4118#> * checking for sufficient/correct file permissions ... OK

4119#> * checking whether package ‘xgboost’ can be installed ... ERROR

4120#> Installation failed.

4121#> See ‘/export/home/XnXaLcc/xgboost.Rcheck/00install.out’ for details.

[trivialfis]

I don't know if there's a way to retrieve that log.

[hetong007]

@trivialfis Seems this is the log: https://artifacts.r-hub.io/xgboost_1.3.2.1.tar.gz-e506d18ec1084d778d4e8299a3d57e91/xgboost.Rcheck/

[trivialfis]

Got it passed: https://builder.r-hub.io/status/xgboost_1.3.2.1.tar.gz-72aa615847ba65333ecfea61c676b7b4 Will open a PR.

[trivialfis]

#6606

[hetong007]

I patched this PR and submitted it to R-hub again, but got an error in installation: https://artifacts.r-hub.io/xgboost_1.3.2.1.tar.gz-5c8a82e1e66188afea79817c398575fd/xgboost.Rcheck/00install.out

[trivialfis]

std::ctype<char>::id ? @hetong007 what's your configuration of testing?

[hetong007]

My configuration on r-hub is:

• Visit https://builder.r-hub.io/advanced
• Select Oracle Solaris 10, x86, 32 bit, R-release, Oracle Developer Studio 12.6 for the platform -- This is the CRAN Soalris config.
• Upload the package, configure the email address
• Start the check and wait.

I can submit again to see if this is a false alarm, will update this thread if ends up with a different result.

[trivialfis]

I hope that we don't have to bisect it on R Hub ....

[trivialfis]

I tried the old 1.2 release, which is also failing due to type check (removed in 1.3): https://artifacts.r-hub.io/xgboost_1.2.0.1.tar.gz-1fa6b58859caf51810b85692f5e870c6/xgboost.Rcheck/00install.out

[hetong007]

Seems the current CRAN error is not the same as what we have on r-hub: https://www.r-project.org/nosvn/R.check/r-patched-solaris-x86/xgboost-00install.html

[trivialfis]

@hetong007 That was fixed in #6578

[trivialfis]

At latest 1.3 branch, all compiler related workarounds/fixes are applied. But the linker issue you found #6571 (comment) is still there, and I'm not sure how to remove it. The std::ctype<char>::id seems to be used in std stream, but I'm not sure which part of xgboost is triggering that error.

[trivialfis]

@hetong007 Can we just submit the package?

[hetong007]

Well if a fix is not easily accessible, I can try to submit. That's at least an action trying to patch.

[trivialfis]

@hetong007 Thanks! Please keep me in the loop if there's any insight on the linker error. I wonder if it's reproducible on CRAN. Since of the 2 Solaris configurations on R Hub, the one that without oracle developer studio is passing.

[trivialfis]

@hcho3 All wheels are uploaded to pypi. Many thanks for the help!