Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of print period in EvaluationMonitor #6499

Merged
merged 2 commits into from Dec 15, 2020

Conversation

ShvetsKS
Copy link
Contributor

@ShvetsKS ShvetsKS commented Dec 14, 2020

Currently verbose_eval parameter is not taking into account due simple typo in callback.py
If we set verbose_eval=100 print log is:

[1] eval-auc:0.54791 train-auc:0.54620
...
[98] eval-auc:0.88926 train-auc:0.90105
[99] eval-auc:0.88921 train-auc:0.90110
[101] eval-auc:0.88928 train-auc:0.90114
...

After fix:
[0] eval-auc:0.53902 train-auc:0.53251
[100] eval-auc:0.88931 train-auc:0.90116
...

Similar to v1.2.0 print log

Copy link
Collaborator

@hcho3 hcho3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@trivialfis Can I also get a review from you?

Copy link
Member

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Could you please help modifying the test test_callback.py::test_evaluation_monitor to capture the fixed error?

@ShvetsKS
Copy link
Contributor Author

Thanks for the fix! Could you please help modifying the test test_callback.py::test_evaluation_monitor to capture the fixed error?

Sure

@trivialfis trivialfis merged commit 8139849 into dmlc:master Dec 15, 2020
@hcho3 hcho3 mentioned this pull request Dec 16, 2020
5 tasks
trivialfis pushed a commit to trivialfis/xgboost that referenced this pull request Dec 20, 2020
Co-authored-by: Kirill Shvets <kirill.shvets@intel.com>
trivialfis added a commit that referenced this pull request Dec 20, 2020
Co-authored-by: Kirill Shvets <kirill.shvets@intel.com>

Co-authored-by: ShvetsKS <33296480+ShvetsKS@users.noreply.github.com>
Co-authored-by: Kirill Shvets <kirill.shvets@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants