Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filtering callable objects in skl xgb param. #6466

Merged
merged 2 commits into from Dec 5, 2020

Conversation

trivialfis
Copy link
Member

Fix #6460 .

@trivialfis trivialfis requested a review from hcho3 December 4, 2020 20:34
@hcho3 hcho3 mentioned this pull request Dec 5, 2020
12 tasks
@hcho3 hcho3 closed this Dec 5, 2020
@hcho3 hcho3 reopened this Dec 5, 2020
@hcho3
Copy link
Collaborator

hcho3 commented Dec 5, 2020

CI is fixed in #6467

@codecov-io
Copy link

codecov-io commented Dec 5, 2020

Codecov Report

Merging #6466 (2fdb981) into master (05e5563) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6466      +/-   ##
==========================================
+ Coverage   80.04%   80.13%   +0.08%     
==========================================
  Files          13       13              
  Lines        3513     3513              
==========================================
+ Hits         2812     2815       +3     
+ Misses        701      698       -3     
Impacted Files Coverage Δ
python-package/xgboost/sklearn.py 89.61% <100.00%> (ø)
python-package/xgboost/tracker.py 95.18% <0.00%> (+1.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05e5563...2fdb981. Read the comment docs.

@trivialfis trivialfis merged commit d6386e4 into dmlc:master Dec 5, 2020
@trivialfis trivialfis deleted the fix-get-xgb-params branch December 5, 2020 09:20
hcho3 added a commit that referenced this pull request Dec 8, 2020
Co-authored-by: Hyunsu Cho <chohyu01@cs.washington.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unknown objective function during predict, only in 1.3.0 RC (1.2.0 ok)
3 participants