Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dask] Allow empty data matrix in AFT survival #6379

Merged
merged 2 commits into from Nov 13, 2020

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Nov 12, 2020

Closes #6139

@trivialfis
Copy link
Member

Actually you might need to add a unittest. The dask interface is no longer using all workers

@hcho3
Copy link
Collaborator Author

hcho3 commented Nov 12, 2020

Any suggestion? Is it sufficient to pass in an empty DMatrix?

@trivialfis
Copy link
Member

Yup.

@codecov-io
Copy link

codecov-io commented Nov 12, 2020

Codecov Report

Merging #6379 (eb58239) into master (d711d64) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6379      +/-   ##
==========================================
+ Coverage   81.27%   81.36%   +0.08%     
==========================================
  Files          12       12              
  Lines        3450     3450              
==========================================
+ Hits         2804     2807       +3     
+ Misses        646      643       -3     
Impacted Files Coverage Δ
python-package/xgboost/tracker.py 95.18% <0.00%> (+1.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d711d64...7d99c85. Read the comment docs.

Copy link
Member

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hcho3 hcho3 merged commit e5193c2 into dmlc:master Nov 13, 2020
@hcho3 hcho3 deleted the allow_empty_aft_survival branch November 13, 2020 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow empty datasets in survival:aft objective and aft-nloglik metric
3 participants