Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python callback. #6320

Merged
merged 2 commits into from Oct 29, 2020
Merged

Fix Python callback. #6320

merged 2 commits into from Oct 29, 2020

Conversation

trivialfis
Copy link
Member

@trivialfis trivialfis commented Oct 29, 2020

Copy the user provided callback parameter. Python is pass by reference, manipulating parameter directly has unexpected result.

Close #6319 .

@trivialfis trivialfis merged commit 6ff331b into dmlc:master Oct 29, 2020
@trivialfis trivialfis deleted the fix-callback branch October 29, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Callback list should be copied.
2 participants