Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loop over reduce. #6229

Merged
merged 1 commit into from Oct 13, 2020
Merged

Loop over reduce. #6229

merged 1 commit into from Oct 13, 2020

Conversation

trivialfis
Copy link
Member

@trivialfis trivialfis commented Oct 13, 2020

  • Document the limitation.
  • Loop over thrust::reduce.
  • Check the batch size.

@codecov-io
Copy link

codecov-io commented Oct 13, 2020

Codecov Report

Merging #6229 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6229   +/-   ##
=======================================
  Coverage   80.80%   80.80%           
=======================================
  Files          12       12           
  Lines        3334     3334           
=======================================
  Hits         2694     2694           
  Misses        640      640           
Impacted Files Coverage Δ
python-package/xgboost/core.py 78.34% <ø> (ø)
python-package/xgboost/dask.py 80.07% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2443275...82d5d4d. Read the comment docs.

* Check input chunk size of dqdm.
* Add doc for current limitation.
@RAMitchell RAMitchell merged commit bed7ae4 into dmlc:master Oct 13, 2020
@trivialfis trivialfis deleted the check-chunk-size branch October 14, 2020 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants