Loop over copy_if #6201
Merged
Loop over copy_if #6201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivialfis
reviewed
Oct 6, 2020
| COOToEntryOp<decltype(batch)> transform_op{batch}; | ||
| thrust::transform_iterator<decltype(transform_op), decltype(counting)> | ||
| transform_iter(counting, transform_op); | ||
| // We loop over batches because thrust::copy_if cant deal with sizes > 2^31 |
There was a problem hiding this comment.
Should we put this into device_helpers.cuh and replace some other copy_if?
There was a problem hiding this comment.
I'd rather do this later.
trivialfis
force-pushed
the
mortgage-fix
branch
from
e3acf86
to
a02cd2c
Compare
This reverts commit 57e9c39.
trivialfis
approved these changes
Oct 13, 2020
RAMitchell
force-pushed
the
mortgage-fix
branch
from
e30d343
to
a9d6135
Compare
RAMitchell
force-pushed
the
mortgage-fix
branch
from
a9d6135
to
61c9a70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loop over batches with copy_if in DMatrix construction, because we get an int overflow with thrust. See: NVIDIA/cccl#747