Improve JSON format for categorical features. #6128
Conversation
trivialfis
commented
Sep 17, 2020
trivialfis
commented
- This PR reduces the saved categories to a single vector instead of vector per-node.
Codecov Report
@@ Coverage Diff @@
## master #6128 +/- ##
=======================================
Coverage 78.52% 78.52%
=======================================
Files 12 12
Lines 3069 3069
=======================================
Hits 2410 2410
Misses 659 659 Continue to review full report at Codecov.
|
|
@trivialfis Do you have performance numbers? How much does this PR improve serialization performance? |
| common::KCatBitField const cat_bits(node_categories); | ||
| for (size_t i = 0; i < cat_bits.Size(); ++i) { | ||
| if (cat_bits.Check(i)) { | ||
| categories.emplace_back(static_cast<Integer::Int>(i)); |
There was a problem hiding this comment.
@trivialfis What's the performance implication of saving individual categories? Is it better than saving bitmaps directly?
There was a problem hiding this comment.
No, it's not. If saving bitmap is preferred I can make the change.
There was a problem hiding this comment.
No, if saving individual categories produces acceptable performance, let's keep it. It's easier to parse by a human.
