Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow kwargs in dask predict #6117

Merged
merged 1 commit into from Sep 15, 2020
Merged

Allow kwargs in dask predict #6117

merged 1 commit into from Sep 15, 2020

Conversation

RAMitchell
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2020

Codecov Report

Merging #6117 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6117   +/-   ##
=======================================
  Coverage   78.52%   78.52%           
=======================================
  Files          12       12           
  Lines        3069     3069           
=======================================
  Hits         2410     2410           
  Misses        659      659           
Impacted Files Coverage Δ
python-package/xgboost/dask.py 78.95% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08bdb2e...a12cef1. Read the comment docs.

Copy link
Member

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So list arguments are not used?

@RAMitchell
Copy link
Member Author

I think requiring explicit kwargs is safer as inputs can't be unintentionally used for the wrong argument.

Copy link
Member

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@RAMitchell RAMitchell merged commit 47350f6 into dmlc:master Sep 15, 2020
@RAMitchell RAMitchell deleted the dask-shap branch September 15, 2020 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants