Expand categorical node. #6028
Merged
Expand categorical node. #6028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test is quite limited as there's no way to build categorical splits right now except for manually expanding nodes. So I will leave better tests for later PRs. |
Codecov Report
@@ Coverage Diff @@
## master #6028 +/- ##
=======================================
Coverage 79.10% 79.10%
=======================================
Files 12 12
Lines 3044 3044
=======================================
Hits 2408 2408
Misses 636 636
Continue to review full report at Codecov.
|
RAMitchell
reviewed
Aug 22, 2020
hcho3
approved these changes
Aug 24, 2020
RAMitchell
approved these changes
Aug 24, 2020
hcho3
reviewed
Aug 24, 2020
Co-authored-by: Philip Hyunsu Cho <chohyu01@cs.washington.edu>
hcho3
approved these changes
Aug 25, 2020
|
This PR brought significant impact on performance as it adds 1 extra vector for each node. I will work on another PR to restore the performance as I can't revert it cleanly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes expanding tree on categorical feature, saving/loading such trees. It's partly extracted from #5949 , with changes that now the saved tree model contains actual categories instead of bitsets.