Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dask] Order the prediction result. #5416

Merged
merged 4 commits into from Mar 15, 2020
Merged

[dask] Order the prediction result. #5416

merged 4 commits into from Mar 15, 2020

Conversation

trivialfis
Copy link
Member

@trivialfis trivialfis commented Mar 14, 2020 •
edited

This PR tries to preserve the ordering of data parts in DaskDMatrix, which is necessary for prediction.

RAMitchell
RAMitchell approved these changes Mar 15, 2020
View reviewed changes
Copy link
Member

@RAMitchell RAMitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My dask fu is not very good but looks okay to me.

@trivialfis trivialfis merged commit 21b671a into dmlc:master Mar 15, 2020
@trivialfis trivialfis deleted the dask-prediction branch March 15, 2020 11:34
trivialfis added a commit to trivialfis/xgboost that referenced this pull request Mar 24, 2020
@trivialfis
[dask] Order the prediction result. (dmlc#5416)
f861c70
@trivialfis trivialfis mentioned this pull request Apr 21, 2020
Closed
12 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RAMitchell RAMitchell RAMitchell approved these changes

Assignees
No one assigned
Labels
Blocking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@trivialfis @RAMitchell