From 45dc1f818aa4fa5fa2e05301e6096897537201ac Mon Sep 17 00:00:00 2001 From: Rong Ou Date: Mon, 27 Jun 2022 02:26:41 -0700 Subject: [PATCH] Make federated plugin work with cmake 3.16.3 (#8029) --- plugin/federated/CMakeLists.txt | 7 ++++--- plugin/federated/README.md | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/plugin/federated/CMakeLists.txt b/plugin/federated/CMakeLists.txt index b84fbb7592a1..39eac924dd89 100644 --- a/plugin/federated/CMakeLists.txt +++ b/plugin/federated/CMakeLists.txt @@ -1,6 +1,6 @@ # gRPC needs to be installed first. See README.md. -find_package(Protobuf REQUIRED) -find_package(gRPC REQUIRED) +find_package(Protobuf CONFIG REQUIRED) +find_package(gRPC CONFIG REQUIRED) find_package(Threads) # Generated code from the protobuf definition. @@ -18,7 +18,8 @@ protobuf_generate( PLUGIN "protoc-gen-grpc=${grpc_cpp_plugin_location}") # Wrapper for the gRPC client. -add_library(federated_client INTERFACE federated_client.h) +add_library(federated_client INTERFACE) +target_sources(federated_client INTERFACE federated_client.h) target_link_libraries(federated_client INTERFACE federated_proto) # Rabit engine for Federated Learning. diff --git a/plugin/federated/README.md b/plugin/federated/README.md index b9574b977e60..5858d7cebf50 100644 --- a/plugin/federated/README.md +++ b/plugin/federated/README.md @@ -7,7 +7,7 @@ Install gRPC ------------ ```shell sudo apt-get install build-essential autoconf libtool pkg-config cmake ninja-build -git clone -b v1.45.2 https://github.com/grpc/grpc +git clone -b v1.47.0 https://github.com/grpc/grpc cd grpc git submodule update --init cmake -S . -B build -GNinja -DABSL_PROPAGATE_CXX_STD=ON