Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docker plugins to use containerd #32

Open
dmcgowan opened this issue Mar 28, 2019 · 2 comments
Open

Update docker plugins to use containerd #32

dmcgowan opened this issue Mar 28, 2019 · 2 comments
Projects
containerd-integration

Comments

@dmcgowan
Copy link
Owner

Docker plugins today are still managed using the now deprecated distribution code. The plugins do not directly integrate with the layer store or support push, but the pull can just containerd's code.

There is another task to integrate the runtime, but that is out of scope here
@dmcgowan dmcgowan added this to To do in containerd-integration via automation Mar 28, 2019
@ddebroy
Copy link

ddebroy commented Apr 20, 2019

Jean Rouge will take a look at this post dockercon

dmcgowan pushed a commit that referenced this issue May 17, 2019
@kolyshkin
Dockerfile.e2e: fix DOCKER_GITCOMMIT handling
c3b2494 
1. There is no need to persist DOCKER_GITCOMMIT,
as it's not needed for runtime, only for build.
So, remove ENV.

2. In case $GITCOMMIT is not defined during build time
(and it happens if .git directory is not present),
we still need to have some value set, so set it to
`undefined`. Otherwise we'll have something like

>  => ERROR [builder 2/3] RUN hack/make.sh build-integration-test-binary
> ------
>  > [builder 2/3] RUN hack/make.sh build-integration-test-binary:
> #32 0.488
> #32 0.505 error: .git directory missing and DOCKER_GITCOMMIT not specified
> #32 0.505   Please either build with the .git directory accessible, or specify the
> #32 0.505   exact (--short) commit hash you are building using DOCKER_GITCOMMIT for
> #32 0.505   future accountability in diagnosing build issues.  Thanks!

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@cpuguy83
Copy link

I'm working on this here: moby#39946

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
containerd-integration
  
To do
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dmcgowan @cpuguy83 @ddebroy