Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade golang.org/x/tools for go 1.18 compatibility #59

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

smlx
Copy link
Contributor

@smlx smlx commented Mar 28, 2022

I have some code with this go:generate command:

//go:generate enumer -type=EnvironmentType -sql -transform=lower

When running go generate ./... with Go 1.18 I was getting an error like this on the latest version of enumer.

enumer: internal error: package "database/sql/driver" without types was imported from "github.com/uselagoon/ssh-portal/internal/lagoon"
internal/lagoon/environmenttype.go:3: running "enumer": exit status 1

This issue hinted that the error was due to an old version of golang.org/x/tools: golang/go#37617

Sure enough, upgrading that dependency and rebuilding enumer allows it to work correctly when using the Go 1.18 standard library.

@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2022

Codecov Report

Merging #59 (df780b2) into master (caff60e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #59   +/-   ##
=======================================
  Coverage   66.23%   66.23%           
=======================================
  Files           4        4           
  Lines         465      465           
=======================================
  Hits          308      308           
  Misses        146      146           
  Partials       11       11           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caff60e...df780b2. Read the comment docs.

@nezorflame
Copy link

@dmarkham any chance we can get this merged?

@dmarkham
Copy link
Owner

@dmarkham any chance we can get this merged?
For sure thank you... let me cut a release.

@dmarkham dmarkham merged commit aa45c0d into dmarkham:master Apr 12, 2022
@smlx smlx deleted the bump-tools branch April 12, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants