Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop old vendor versions #86

Merged
merged 1 commit into from Jul 10, 2019
Merged

drop old vendor versions #86

merged 1 commit into from Jul 10, 2019

Conversation

garak
Copy link
Contributor

@garak garak commented Jul 10, 2019

See issue #81
If merged, a new tag should be created (branch alias already provided in this PR)

dmaicher
dmaicher reviewed Jul 10, 2019
View reviewed changes
Copy link
Owner

@dmaicher dmaicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

it also means we can simplify this listener, right?

https://github.com/dmaicher/doctrine-test-bundle/blob/master/src/DAMA/DoctrineTestBundle/PHPUnit/PHPUnitListener.php#L8

And probably we need to update the readme slightly

.travis.yml Show resolved Hide resolved
@garak
Copy link
Contributor Author

garak commented Jul 10, 2019

@dmaicher done (and squashed, sorry for doing lot of tries)

@dmaicher
Copy link
Owner

Thanks a lot @garak. Will release a new major soon 👍

@dmaicher dmaicher merged commit 39de47f into dmaicher:master Jul 10, 2019
@garak garak deleted the increase-requirements branch July 10, 2019 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmaicher dmaicher dmaicher left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@garak @dmaicher