Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document Behat support #80

Merged
merged 2 commits into from Apr 9, 2019
Merged

Document Behat support #80

merged 2 commits into from Apr 9, 2019

Conversation

mnapoli
Copy link
Contributor

@mnapoli mnapoli commented Apr 5, 2019

See #48

@mnapoli mnapoli mentioned this pull request Apr 5, 2019
Closed
@dkarlovi
Copy link

dkarlovi commented Apr 5, 2019

@mnapoli does this mean you've changed your mind about behat? 😀

@mnapoli
Copy link
Contributor Author

mnapoli commented Apr 5, 2019

@dkarlovi haha I have to work with Behat for a client. It's OK, but I still think it could be better with PHPUnit (especially since it's an HTTP API with loads of JSON in Gherkin) :)

dmaicher
dmaicher reviewed Apr 9, 2019
View reviewed changes
Copy link
Owner

@dmaicher dmaicher left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to make clear that this will not work if you use a web-server for testing like with selenium and a web-browser like chrome/firefox.

This will only work if the application code is executed within the same php process as the behat tests.

@mnapoli
Copy link
Contributor Author

mnapoli commented Apr 9, 2019

@dmaicher good point, just updated the PR!

dmaicher
dmaicher approved these changes Apr 9, 2019
View reviewed changes
Copy link
Owner

@dmaicher dmaicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice

@dmaicher
Copy link
Owner

dmaicher commented Apr 9, 2019

Thanks @mnapoli !

@dmaicher dmaicher merged commit 1e8e3c5 into dmaicher:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@B-Galati B-Galati B-Galati approved these changes

@dmaicher dmaicher dmaicher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mnapoli @dkarlovi @dmaicher @B-Galati