TypeError : Return value of DAMA\DoctrineTestBundle\Doctrine\DBAL\StaticDriver::getDatabase() must be of the type string, null returned

[klodoma]

<?php

namespace DAMA\DoctrineTestBundle\Doctrine\DBAL;

class StaticDriver implements Driver, ExceptionConverterDriver, VersionAwarePlatformDriver

    /**
     * {@inheritdoc}
     */
    public function getDatabase(\Doctrine\DBAL\Connection $conn): string
    {
        return $this->underlyingDriver->getDatabase($conn);
    }

If you use an in-memory database
<env name="DATABASE_URL" value="sqlite:///:memory:"/>

then this leads to a type error:

TypeError : Return value of DAMA\DoctrineTestBundle\Doctrine\DBAL\StaticDriver::getDatabase() must be of the type string, null returned

A in memory sqlite goes in here and returns NULL and not string(has no path)

    /**
     * {@inheritdoc}
     */
    public function getDatabase(Connection $conn)
    {
        $params = $conn->getParams();

        return $params['path'] ?? null;
    }

Just changing

public function getDatabase(\Doctrine\DBAL\Connection $conn): ?string

fixes the issue.

[dmaicher]

See #115

Indeed the AbstractSQLiteDriver may return null although the phpdoc annotates the method with return type string on the Driver interface 😕

https://github.com/doctrine/dbal/blob/2.11.x/lib/Doctrine/DBAL/Driver.php#L56

[dmaicher]

new release 6.3.2 tagged 😉

[klodoma]

Thank you!