New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to use the new Sass JS API by default #846
base: master
Are you sure you want to change the base?
Conversation
Keep the legacy API around, since its removal is still probably a while from now. Fixes dlmanning#837
Add a migration section, link to relevant Sass documentation, and add a section about still using the legacy API.
Hei William, thanks a lot for pushing this! I played around with your branch and wasn't able to
(it's an old project, don't ask…). I have passed 'node_modules' as an |
If that doesn't work, we use a |
Thanks, that does it! 👍 Unfortunately the compile time I see is still about twice as high when compared to the legacy |
Speed benefits will probably depend on you also using sass-embedded instead of the regular |
I just tested this branch with Not surprisingly, the |
One of the goals of Footnotes
|
Indeed. I only use the globber as a convenience for importing all my mixins with one line instead of one-by-one. If someone wanted to implement a new globber, I think the simpler FileImporter API would be a better fit than the full Importer API. To be clear, I do not consider a lack of a globber a show stopper for this PR. I'm using this branch now for a new project and hope it will be merged soon. Thanks for your work, @wkillerud! |
Would love to see this merged. Have tested myself and is working and I am using it succesfully with sass-embedded. Notes are.
|
The legacy render API will be removed in sass 2.0. Keep the legacy API as an option, but default to the new API to encourage adoption.
Add
sass-embedded
in tests and update assertions to support the results from v2 of the JS API.Fixes #837