Refactor/remove python 2 code #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there, Good idea, thanks for taking this on! Since this is a large PR, please allow some additional time for review. Briefly looking over the PR, can you remove changes unrelated to removing Python 2.7 code? We can move single -> double quotes, shift whitespace around, etc, but that would be easier to do in a separate change, and would make review of this code easier. Thanks again! |
jkklapp
force-pushed
the
refactor/remove-python-2-code
branch
from
dccb7dd
to
987236e
Compare
jkklapp
force-pushed
the
refactor/remove-python-2-code
branch
from
987236e
to
ce0abed
Compare
|
@mschwager I made the changes you requested |
|
Excellent, thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #40