Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive in redos detection when re.DOTALL missing #20

Open
mschwager opened this issue Feb 20, 2020 · 0 comments
Open

False positive in redos detection when re.DOTALL missing #20

mschwager opened this issue Feb 20, 2020 · 0 comments

Comments

@mschwager
Copy link
Contributor

The following expression doesn't ReDoS, but Dlint detects it:

re.search(r'(\n.*)+a', '\n' * 64 + 'b')

However, this expression does ReDoS:

re.search(r'(\n.*)+a', '\n' * 64 + 'b', re.DOTALL)

Fixing this requires a large amount of work for little gain in reducing false positives. The first example doesn't seem very common. We don't currently analyze the flags passed to re functions, so adding this functionality would take considerable work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant