Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to tokio 0.3 #82

Closed
krojew opened this issue Oct 19, 2020 · 11 comments
Closed

Update to tokio 0.3 #82

krojew opened this issue Oct 19, 2020 · 11 comments

Comments

@krojew
Copy link

krojew commented Oct 19, 2020

Since tokio 0.3 is out with some major changes, it would be a good idea to update.

@djc
Copy link
Owner

djc commented Oct 19, 2020

bb8-redis depends on redis, which needs to upgrade.

@djc
Copy link
Owner

djc commented Oct 19, 2020

We also have an example that depends on hyper.

@krojew
Copy link
Author

krojew commented Oct 19, 2020

You can wrap them in tokio-compat-02.

@djc
Copy link
Owner

djc commented Oct 19, 2020

That seems like extra work, for the limited gain of having bb8 on tokio 0.3 a little sooner. I'm unlikely to do it (unless you want to fund the work), although I'll review it if you want to do the legwork.

@krojew
Copy link
Author

krojew commented Oct 19, 2020

The problem with bb8 on tokio 0.2 now is that it cannot be used by applications using 0.3, even with the compatibility layer. Any future returned by bb8 must be wrapped in a 0.2 wrapper, but if it then calls a future from 0.3, for example anything net related, the process panics.

@djc
Copy link
Owner

djc commented Oct 19, 2020

I'm aware of this, but I don't feel that keeping your application on 0.2 a little while longer is a big deal.

@djc
Copy link
Owner

djc commented Nov 5, 2020

I've pushed a branch which has bb8 and bb8-postgres working on tokio 0.3. I've temporarily removed the bb8-redis crate and the postgres hyper example from this branch, and will add them back as hyper/redis release new versions.

@djc
Copy link
Owner

djc commented Nov 5, 2020

Would be happy to get any feedback on this branch, but the changes were very minor anyway.

@krojew
Copy link
Author

krojew commented Nov 6, 2020

Looks like it's working.

@djc
Copy link
Owner

djc commented Nov 16, 2020

I've released version 0.6.0 of bb8 and bb8-postgres with tokio 0.3 support.

@djc djc closed this as completed Nov 16, 2020
@djc
Copy link
Owner

djc commented Dec 3, 2020

I've just released bb8-redis 0.7, which supports tokio 0.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants