Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Redis Sentinel Authentication (SENTINEL_KWARGS) #300

Closed
K-MTG opened this issue Mar 6, 2022 · 3 comments · Fixed by #318
Closed

Support Redis Sentinel Authentication (SENTINEL_KWARGS) #300

K-MTG opened this issue Mar 6, 2022 · 3 comments · Fixed by #318

Comments

@K-MTG
Copy link

K-MTG commented Mar 6, 2022

Current config does not appear to allow me to define SENTINEL_KWARGS where I can specify a sentinel password for sentinel authentication.

This appears to be a limitation with the current version of airoredis as support was added in 2.0: aio-libs-abandoned/aioredis-py#690
@carltongibson
Copy link
Member

Yep, this is a duplicate of #285

@andriilahuta
Copy link
Contributor

@carltongibson can we reopen this since it's no longer related to #285?

I think we can put sentinel_kwargs here and it should just work:

channels_redis/channels_redis/core.py

Line 138 in d946ce2

master_name, aioredis.sentinel.Sentinel(sentinels), **host

@carltongibson
Copy link
Member

@andriilahuta OK, yep. If you want an open a PR with tests for that we can have a look. Thanks. 👍

@carltongibson carltongibson reopened this Jul 18, 2022
@andriilahuta andriilahuta mentioned this issue Jul 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sentinel authentication (sentinel_kwargs) andriilahuta/channels_redis
3 participants
@carltongibson @andriilahuta @K-MTG