Skip to content

Update testing.rst #1573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2020
Merged

Update testing.rst #1573

merged 1 commit into from
Nov 12, 2020
+2 −2

Conversation

XSPGMike
Copy link
Contributor

I was setting up my tests to keep up with channels 3.0 and I incurred in this issue, if I am not getting something about this let me know please.

@XSPGMike
Update testing.rst

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
05f86d3 
I was setting up my tests to keep up with channels 3.0 and I incurred in this issue, if I am not getting something about this let me know please.
carltongibson
carltongibson approved these changes Nov 12, 2020
View reviewed changes
Copy link
Member

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good thanks.

For a test, likely you can just instantiate the consumer for a single request — like SimpleWebsocketApp() — but as_asgi() is the right approach.

Thanks!

@carltongibson carltongibson merged commit c7ea04f into django:master Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carltongibson carltongibson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@XSPGMike @carltongibson