Added coroutine detection shims for Python 3.12 #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carltongibson
force-pushed
the
iscoroutinefunction-shim
branch
from
2103179
to
a6a4ca4
Compare
|
Lint failure is a pre-commit fetching from GitLab error. |
|
I'm hoping the Python PR can make it into the next Python 3.12 alpha. Ideally we could get this into an asgiref version for the 4.2a1 release, due Jan 16th. //cc @felixxm |
🤞 |
This comment was marked as resolved.
This comment was marked as resolved.
Refs: python/cpython#99247 This would be needed for Django 4.2, which would support PY312 on release of that.
carltongibson
force-pushed
the
iscoroutinefunction-shim
branch
from
8c667a5
to
1689063
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: python/cpython#99247
This would be needed for Django 4.2, which would support PY312 on release of that.
Adds
markcoroutinefunction()andiscoroutinefunctionshims, and makes use of those internally.