Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate package for asgiref/typing.py #333

Open
relsunkaev opened this issue Jun 8, 2022 · 2 comments
Open

Separate package for asgiref/typing.py #333

relsunkaev opened this issue Jun 8, 2022 · 2 comments

Comments

@relsunkaev
Copy link

For those who just want to use this library for typing their ASGI apps/servers (namely uvicorn and starlette), it doesn't make much sense to depend on the entirety of this package just for the types. Would you be open to splitting out the types into a separate package (django/asgitypes perhaps?) and have asgiref depend on that instead? That way package maintainers are more incentivized to type their packages and, possibly, adhere to the spec more closely.

@Kludex
Copy link
Contributor

Kludex commented Jun 12, 2022

I've created https://github.com/Kludex/asgi-types for the time being.

I'm willing to transfer the repository to django if wanted.

@adriangb
Copy link
Contributor

+1 to this, I think it would be a good move for the ecosystem in general and a backwards compatible change for asgiref.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants