Preserve CurrentThreadExecutor across create_task #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersk
force-pushed
the
current-executor
branch
5 times, most recently
from
c85be5f
to
3ae7bd4
Compare
Fixes django#214. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
andersk
force-pushed
the
current-executor
branch
from
3ae7bd4
to
5a4911b
Compare
|
@andrewgodwin Can I ask whether this approach makes sense for upstream? I understand if the actual merging and release might be slow for various reasons—but I want to make sure I won’t be stuck maintaining a permanent fork of asgiref for Zulip. |
|
Ah, sorry, this PR totally slipped out of my attention. It looks good! |
|
@andersk FYI, this is now out in 3.5.1 so you can hopefully undo any forking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #214.