Drop Python 3.6 #307
Merged
Drop Python 3.6 #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should remove the vendored pep as well |
|
Lovely, this is a pretty significant cleanup. You love to see it. |
|
@Kludex do you mean pep562? What did I miss? |
|
Ah, you did remove it! Sorry. For some reason I didn't see the full diff before. |
|
np. It's prob because deleted files don't show a full diff, only a sliver of gray with the file name on GitHub. |
|
Yeah, the diff and removal of the vendored backport all looked good to me! |
|
There's still this bit in Lines 29 to 30 in 02fecb6 A future PR should probably make that module use |
|
Yes, a separate PR is needed. I lost a lot of time due to start of school, so I can't make that local PR. Sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.6 EOL is soon (apparently it's today!). Dropping some compatibility. Hoping to add a PR for Local soon.