From d451a724c93043b623e83e7f86743bbcd9a05c45 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rafael=20Fern=C3=A1ndez=20L=C3=B3pez?= Date: Fri, 1 Apr 2022 16:47:46 +0200 Subject: [PATCH] Remove `SOCK_NONBLOCK` from socket creation on tests (#321) This fixes running tests on Mac OS X, which lacks the `SOCK_NONBLOCK` socket flag creation. --- .pre-commit-config.yaml | 2 +- tests/test_server.py | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 8a050774..0379a317 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -6,7 +6,7 @@ repos: args: ["--py37-plus"] - repo: https://github.com/psf/black - rev: 20.8b1 + rev: 22.3.0 hooks: - id: black args: ["--target-version=py37"] diff --git a/tests/test_server.py b/tests/test_server.py index 8f86096d..616ccf21 100644 --- a/tests/test_server.py +++ b/tests/test_server.py @@ -21,7 +21,8 @@ def __init__(self, application, max_applications=1000): application, max_applications=max_applications, ) - self._sock = sock.socket(sock.AF_INET, sock.SOCK_DGRAM | sock.SOCK_NONBLOCK) + self._sock = sock.socket(sock.AF_INET, sock.SOCK_DGRAM) + self._sock.setblocking(False) self._sock.bind(("127.0.0.1", 0)) @property @@ -54,7 +55,8 @@ def close(self): class Client: def __init__(self, name): - self._sock = sock.socket(sock.AF_INET, sock.SOCK_DGRAM | sock.SOCK_NONBLOCK) + self._sock = sock.socket(sock.AF_INET, sock.SOCK_DGRAM) + self._sock.setblocking(False) self.name = name async def register(self, server_addr, name=None):