Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http links in index #6

Open
psegs9 opened this issue Apr 26, 2024 · 0 comments
Open

http links in index #6

psegs9 opened this issue Apr 26, 2024 · 0 comments

Comments

@psegs9
Copy link

psegs9 commented Apr 26, 2024

The protocol part of the link to the documentation (and the two other options in that list) is hardcoded to http (no s). It's a bit irritating nowadays to have the crossed out lock to appear on a page especially if there is https available.

<li><a href="http://latest.oscarcommerce.com" class="btn btn-primary" title="Try the sandbox">Browse the sandbox</a></li>
<li><a href="http://github.com/django-oscar/django-oscar/" class="btn btn-primary" title="View the source code">View the source code</a></li>
<li><a href="http://docs.oscarcommerce.com/en/latest/" class="btn btn-default" title="Read the documentation">Read the documentation</a></li>

I would make a PR, but am not sure, since there are two sensible options:

  • omit the protocol:
<li><a href="//latest.oscarcommerce.com" class="btn btn-primary" title="Try the sandbox">Browse the sandbox</a></li>
<li><a href="//github.com/django-oscar/django-oscar/" class="btn btn-primary" title="View the source code">View the source code</a></li>
<li><a href="//docs.oscarcommerce.com/en/latest/" class="btn btn-default" title="Read the documentation">Read the documentation</a></li>
  • or add an s to the http
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant