Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deepcopy should not cause a recursion error on the ProductAttributesC… #4018

Merged
merged 2 commits into from Dec 1, 2022

Conversation

specialunderwear
Copy link
Member

…ontainer

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Merging #4018 (868f4ff) into master (44ce5c3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4018   +/-   ##
=======================================
  Coverage   87.18%   87.19%           
=======================================
  Files         291      291           
  Lines       15812    15815    +3     
=======================================
+ Hits        13786    13790    +4     
+ Misses       2026     2025    -1     
Impacted Files Coverage Δ
src/oscar/apps/catalogue/product_attributes.py 90.27% <100.00%> (+1.87%) ⬆️

@joeyjurjens joeyjurjens merged commit c4ebfa6 into master Dec 1, 2022
@joeyjurjens joeyjurjens deleted the fixes-recursion-error-on-deepcopy branch December 1, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants