show boolean option value to yes/no in stead of true/false #4005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you also add unit tests here? |
specialunderwear
requested changes
Nov 16, 2022
| @property | ||
| def _boolean_as_text(self): | ||
| if self.value: | ||
| return (_("Yes")) |
There was a problem hiding this comment.
i forgot to remove it. its fixed now
wlaw01
requested review from
specialunderwear
and removed request for
specialunderwear
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4005 +/- ##
==========================================
- Coverage 87.18% 87.18% -0.01%
==========================================
Files 291 291
Lines 15798 15812 +14
==========================================
+ Hits 13774 13786 +12
- Misses 2024 2026 +2
|
specialunderwear
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.