Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sendmail no try catch block #3952

Open
Bastilla123 opened this issue Jul 22, 2022 · 1 comment
Open

Sendmail no try catch block #3952

Bastilla123 opened this issue Jul 22, 2022 · 1 comment

Comments

@Bastilla123
Copy link

Found a bug? Please fill out the sections below.

Issue Summary

When i submit a order a email is send to receiver. In Method is missing a try catch block and then when receiver-address is wrong or SMTP Server data is wrong payment is not successfull and message to customer is not good. Please make a try catch block to

venv/lib/python3.8/site-packages/oscar/apps/communication/utils.py Line 128

Steps to Reproduce

It's essential that you provide enough information for someone else to replicate the problem you're seeing. Simply describing something that's broken on your current project is not enough!

  1. Insert in settings.py wrong SMTP data
  2. Buy Product and on place order site place this order. Then browser loads approx. 1 Min and then you get error on backend and user get a misterious message

Any other relevant information. For example, why do you consider this a bug and what did you expect to happen instead?

Technical details

  • Python version: Run 3.8.
  • Django version: 3.2
  • Oscar version: Look in your requirements.txt, or run 3.1.
@joeyjurjens
Copy link
Contributor

We could add try-except block and log the exception rather than letting it raise.
However, most projects (I hope) override this method by implementing their chosen que/task system for mailing (such as celery, uwsgi-spooler, django-mailer etc), so I'm not sure if it really is a issue.

@specialunderwear thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants