Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamping the Express Documentation from the Oscar Upgrade #216

Open
daniel-butler opened this issue May 24, 2020 · 3 comments
Open

Revamping the Express Documentation from the Oscar Upgrade #216

daniel-butler opened this issue May 24, 2020 · 3 comments

Comments

@daniel-butler
Copy link
Contributor

The #176 update made some of the getting started documentation out of date. I love the progress and keeping up with the newest LTS versions!

The pull request #215 was only a minor fix to the buyer/seller verbage. I'll keep all of the other changes in this Issue.

First is this section no longer works

urls.py

from django.contrib import admin
from oscar.app import shop

from paypal.express.dashboard.app import application

urlpatterns = [
    url(r'^admin/', admin.site.urls),
    url(r'^checkout/paypal/', include('paypal.express.urls')),
    # Optional
    url(r'^dashboard/paypal/express/', application.urls),
    url(r'', shop.urls),
]

it looks like this has all been refactored into the paypal/payflow/dashboard/apps.py module. However when creating an application we are missing the following OscarDashboardConfig Parameters

from paypal.payflow.dashboard.apps import PayFlowDashboardApplication

application = PayFlowDashboardApplication(
    app_name=,  # missing
    app_module=, # missing
    namespace=,  # looks like it is in the file but isn't being brought into the intialization
)

Documentation page

@daniel-butler
Copy link
Contributor Author

Checkout Button to match the new Oscar bootstrap layout, but it doesn't seem like this is the right way to implement this and should actually be in the payments page.

{% extends 'oscar/basket/partials/basket_content.html' %}
{% load i18n %}

{% block formactions %}
  <div class="form-group clearfix">
    <div class="row">
      {% if annon_checkout_allowed or request.user.is_authenticated %}
      <div class="col-sm-4">
          <a href="{% url 'paypal-redirect' %}">
            <img
                    src="https://www.paypal.com/en_US/i/btn/btn_xpressCheckout.gif"
                    alt="paypal checkout"
                    align="left"
                    style="margin-right: 7px;" />
            </a>
      </div>
        <div class="col-sm-4 col-sm-offset-4">
          <a href="{% url 'checkout:index' %}" class="pull-right btn btn-large btn-primary">{% trans "Proceed to checkout" %}</a>
        </div>
      {% else %}
        <div class="col-sm-4 col-sm-offset-8">
          <a href="{% url 'checkout:index' %}" class="pull-right btn btn-large btn-primary">{% trans "Proceed to checkout" %}</a>
        </div>
      {% endif %}
    </div>
  </div>
{% endblock %}

@daniel-butler
Copy link
Contributor Author

Rename Paypal Express to Paypal Checkout because paypal changed the name Article describing the name change

PayPal's Checkout Website

@mykhul
Copy link

mykhul commented May 26, 2020

I have just discovered this documentation issue which led me to this thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants