Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if we can always use ES6 completions instead of searching in edgengrams #4

Open
specialunderwear opened this issue Jun 23, 2019 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@specialunderwear
Copy link
Member

Currently, in an effort not to change any existing functionality, when searching for completions using typeahead when someone types into the search bar, the ES6 completions functionality is used. The existing suggestion functionality that uses edgengrams is left intact. Most likely the completions functionality can fully replace the existing suggestions functionality.

Test and verify that replacing suggestions using edgengrams with ES6 completions works properly and then implement the replacement.

@specialunderwear specialunderwear added the help wanted Extra attention is needed label Jun 23, 2019
@specialunderwear
Copy link
Member Author

specialunderwear commented Jun 23, 2019

Here is the code that adds the _auto_complete fields based on all the AutocompleteField declarations on the models. Each AutocompleteField now yields both and edgengram in the mapping and a completion field. Would be nice if we could drop the edgengrams.

https://github.com/specialunderwear/django-oscar-elasticsearch/blob/master/oscar_elasticsearch/search/search.py#L63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant