Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement get_serializer_class for read and write serializers #132

Open
maerteijn opened this issue Aug 20, 2018 · 3 comments
Open

Implement get_serializer_class for read and write serializers #132

maerteijn opened this issue Aug 20, 2018 · 3 comments
Labels
enhancement help wanted

Comments

@maerteijn
Copy link
Member

maerteijn commented Aug 20, 2018 •
edited

That's why all the HTML forms in the Browsable API are all not working. We should fix this according to https://www.django-rest-framework.org/api-guide/generic-views/#get_serializer_classself

Would also be needed for generating a correct OpenAPI specification for it.
@maerteijn maerteijn mentioned this issue Aug 20, 2018
Merged
@maerteijn maerteijn changed the title We use serializer_class in the views for output but it should be used for input. We use serializer_class in the API views for output but it should be used for input. Aug 20, 2018
@maerteijn maerteijn changed the title We use serializer_class in the API views for output but it should be used for input. Implement get_serializer_class for read and write serializers Jan 15, 2019
@maerteijn maerteijn removed the bug label Jan 15, 2019
@andruten andruten mentioned this issue May 30, 2019
Merged
14 tasks
@andruten
Copy link

I'm working on it. I've started with the basket views. Can i also change some APIView with a generic view?
I'll create a pull request with the work in progress.

@specialunderwear
Copy link
Member

No you can not change APIView to a generic view because that would disable all the permissions and also the response format stuff. It would be really difficult to recreate all that.

@bboyadao
Copy link

can we use https://github.com/tfranzel/drf-spectacular ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@specialunderwear @maerteijn @andruten @bboyadao