Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recording payment method used #21

Open
maiksprenger opened this issue Nov 13, 2015 · 0 comments
Open

Recording payment method used #21

maiksprenger opened this issue Nov 13, 2015 · 0 comments

Comments

@maiksprenger
Copy link
Member

We recently chatted about an Oscar-friendly way to expose the payment method that a user selected on Adyen. It's not pressing for us to implement, so I'm recording our findings in this issue.

Looking at payment.Source and payment.SourceType, it looks entirely reasonable to me that django-oscar-adyen is allowed to get_or_create an Adyen source, and create a SourceType instance for each payment when recording successful payments.

As we already record the Adyen transaction ID in PaymentEvent, I would feel comfortable
recording the payment method in payment.Source.reference. Sounds sane, and it's not unlikely that was the intention of the (rather vaguely defined) field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant