Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed has-danger from bootstrap4 templates #1168

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

smithdc1
Copy link
Member

@smithdc1 smithdc1 commented Jun 3, 2021

has-danger is not required for bootstrap4. Here's an image showing that the error inputs still work with this change.

image

@smithdc1 smithdc1 linked an issue Jun 3, 2021 that may be closed by this pull request
@smithdc1 smithdc1 added this to the 1.12.0 milestone Jun 3, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2021

Codecov Report

Merging #1168 (f4d6ab6) into main (a5cef68) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1168   +/-   ##
=======================================
  Coverage   97.20%   97.20%           
=======================================
  Files          23       23           
  Lines        2867     2867           
  Branches      243      243           
=======================================
  Hits         2787     2787           
  Misses         39       39           
  Partials       41       41           
Flag Coverage Δ
unittests 97.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5cef68...f4d6ab6. Read the comment docs.

@smithdc1 smithdc1 merged commit 0a7f429 into django-crispy-forms:main Jun 3, 2021
@smithdc1 smithdc1 deleted the has-danger branch June 3, 2021 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove has-danger in bootstrap4 pack
2 participants