Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.12 #1165

Merged
merged 2 commits into from
Jun 11, 2021
Merged

Version 1.12 #1165

merged 2 commits into from
Jun 11, 2021

Conversation

smithdc1
Copy link
Member

@smithdc1 smithdc1 commented May 25, 2021

There is rather alot of code on the shelf with 20 changes since the last release. I'm really pleased with what's in this one, resolving a long standing grouped inputs bug and confirming support for Django 3.2 are the benefits from a user perspective.

The addition of the optgroups filter is a nice win from a maintenance perspective as it should simplify the templates somewhat.

  • Update the release date.

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2021

Codecov Report

Merging #1165 (e602a37) into main (0a7f429) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1165   +/-   ##
=======================================
  Coverage   97.20%   97.20%           
=======================================
  Files          23       23           
  Lines        2867     2867           
  Branches      243      243           
=======================================
  Hits         2787     2787           
  Misses         39       39           
  Partials       41       41           
Flag Coverage Δ
unittests 97.20% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crispy_forms/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a7f429...e602a37. Read the comment docs.

@smithdc1 smithdc1 added this to the 1.12.0 milestone May 25, 2021
@smithdc1
Copy link
Member Author

smithdc1 commented Jun 1, 2021

I've created a regression in a7c0c15

While checking the comment there that radios are completely broken I went back and did some more testing. While I can't yet replicate the users feedback (works for me) we're now getting a rather odd layout for error messages. 🕵️

image

@smithdc1 smithdc1 force-pushed the version1.12 branch 2 times, most recently from 2edbf75 to f15832f Compare June 3, 2021 07:57
@smithdc1
Copy link
Member Author

I've created a regression in a7c0c15

Fixed in a5cef68

@smithdc1 smithdc1 merged commit 1635074 into django-crispy-forms:main Jun 11, 2021
@smithdc1 smithdc1 deleted the version1.12 branch June 11, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants