Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added guidance for custom widgets #1158

Merged
merged 1 commit into from
May 15, 2021

Conversation

smithdc1
Copy link
Member

We see a number of issues where folk are trying to use custom widgets in their form (#768, #971 etc). Given the myriad of things these could be I'm not sure there's a simple generic answer that could work.

I think the best we can do is to guide folk to use a custom template, as this is feeling quite bespoke at this point?

Closes #768
Closes #971

@codecov-commenter
Copy link

codecov-commenter commented May 11, 2021

Codecov Report

Merging #1158 (1edab21) into main (f5185a1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1158   +/-   ##
=======================================
  Coverage   97.24%   97.24%           
=======================================
  Files          23       23           
  Lines        2906     2906           
  Branches      243      243           
=======================================
  Hits         2826     2826           
  Misses         39       39           
  Partials       41       41           
Flag Coverage Δ
unittests 97.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5185a1...1edab21. Read the comment docs.

Copy link
Collaborator

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. 😃

A widget is at least 50% the actual HTML it generates. I think this is fair

@smithdc1
Copy link
Member Author

Thank you for the review! 👍

@smithdc1 smithdc1 merged commit 877dda9 into django-crispy-forms:main May 15, 2021
@smithdc1 smithdc1 deleted the custom-widgets branch May 15, 2021 08:19
@smithdc1 smithdc1 added this to the Next Release milestone May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

simple-captcha validation error is not shown CKEditorWidget incompatible with crispy forms
3 participants