Removed empty "for" attribute for checkboxes #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `id_for_label` is None for CheckboxSelectMultiple when rendering the field label. This change avoids rendering `for=""` in this scenario. See https://github.com/django/django/blob/main/django/forms/widgets.py#L784
Codecov Report
@@ Coverage Diff @@
## main #1157 +/- ##
=======================================
Coverage 97.24% 97.24%
=======================================
Files 23 23
Lines 2906 2906
Branches 243 243
=======================================
Hits 2826 2826
Misses 39 39
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
id_for_labelis None for CheckboxSelectMultiple when rendering the field label. This change avoids renderingfor=""in this scenario. See https://github.com/django/django/blob/main/django/forms/widgets.py#L784I looked at the other Bootstrap templates and they seem to use
field.auto_idinstead offield.id_for_label. Think we'll leave those alone.