Fixed Grouped Choices for Radios and Checkboxes #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smithdc1
commented
May 9, 2021
...ests/results/bootstrap4/test_layout/test_use_custom_control_is_used_in_checkboxes_false.html
Outdated
Show resolved
Hide resolved
...ests/results/bootstrap4/test_layout/test_use_custom_control_is_used_in_checkboxes_false.html
Outdated
Show resolved
Hide resolved
...rms/tests/results/bootstrap4/test_layout/test_use_custom_control_is_used_in_radio_false.html
Show resolved
Hide resolved
This was referenced May 9, 2021
smithdc1
force-pushed
the
group_inputs
branch
4 times, most recently
from
97b91a7
to
d937f5d
Compare
|
A picture says thousand words. I think this is looking ok, any comments? Before After After with failing validation |
|
Hi @smithdc1 could you please re-examine this PR. It seems like it's been the cause of quite a number of issues raised for django-crispy-forms. I think we could probably find a way to re-do this that doesn't necessarily break a lot of the existing implementations. I ask because you're a lot more familiar with the code base. All the same, I want to really thank you for everything you've done to make this possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So here we are 馃帀 This fixes the long standing bug with grouped choices sets.
Fixes #690 and Follows #1119 and #813
I'll leave this here for comments, and look at pulling some of the related changes into separate PRs. There's also a few things which I want to take a closer look at.
requiredattribute ontest_use_custom_control_is_used_in_radio_true.html