Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #1129: render all widget attributes for file fields in bootsrap4 #1130

Merged
merged 1 commit into from
Mar 16, 2021
Merged

Fixed #1129: render all widget attributes for file fields in bootsrap4 #1130

merged 1 commit into from
Mar 16, 2021

Conversation

anneFly
Copy link
Contributor

@anneFly anneFly commented Mar 15, 2021

I've explained the issue a bit more in #1129 .
The main change is that the template now uses widget.data.attrs and that widget.data.attrs.class is explicitly rendered when it's there. Please let me know if you need more/different test coverage or different naming.

@codecov-io
Copy link

codecov-io commented Mar 15, 2021

Codecov Report

Merging #1130 (86ee486) into master (56a423e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1130      +/-   ##
==========================================
+ Coverage   97.23%   97.24%   +0.01%     
==========================================
  Files          23       23              
  Lines        2816     2829      +13     
  Branches      243      243              
==========================================
+ Hits         2738     2751      +13     
  Misses         38       38              
  Partials       40       40              
Flag Coverage Δ
unittests 97.20% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crispy_forms/tests/forms.py 100.00% <100.00%> (ø)
crispy_forms/tests/test_layout.py 99.72% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56a423e...86ee486. Read the comment docs.

@smithdc1
Copy link
Member

Hi Anne -- Thanks for this, it looks good to me.

The tests don't seem to be running, I've tried to restart them but it seems a bit stuck 🕵️ -- https://github.com/django-crispy-forms/django-crispy-forms/actions/runs/655500429

If it's still not completed in the morning, could you try rebasing to see if that spurs it into life?

@anneFly
Copy link
Contributor Author

anneFly commented Mar 16, 2021

@smithdc1 looks like the tests have been running by now. All green :)

@smithdc1
Copy link
Member

@anneFly that's good news. Thanks again for the contribution!

@smithdc1 smithdc1 merged commit 7588f3d into django-crispy-forms:master Mar 16, 2021
@anneFly anneFly deleted the issue-1129-bootstrap4-field-file branch March 16, 2021 09:42
@smithdc1 smithdc1 added this to the Next Release milestone Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants