Added html parsing tools for testing #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the expected html to be stored in an HTML file. Tests can then assert the layout of the whole form.
Codecov Report
@@ Coverage Diff @@
## master #1128 +/- ##
==========================================
+ Coverage 97.23% 97.24% +0.01%
==========================================
Files 23 23
Lines 2816 2836 +20
Branches 243 243
==========================================
+ Hits 2738 2758 +20
Misses 38 38
Partials 40 40
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
carltongibson
approved these changes
Mar 15, 2021
There was a problem hiding this comment.
Hey @smithdc1 鈥斅營 think this is a good move. Having the HTML as strings in the tests has been a pain point 鈮坒orever 鈥斅爏o attacking that has to be a win. 馃憤
|
Thanks Carlton! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the expected html to be stored in an HTML file. Tests can then assert the layout of the whole form.
I've been using this method with the bootstrap5 template pack and have been enjoying working in this way.
I'd like to introduce this here as I think it is helpful generally, I find that tests are more readable as you can see all of the output. It's also then easier to have a discussion about if there is an issue as you can point to the line in the html code that is in question.
More specifically I think it will be helpful to prove the optgroup filter and upcoming changes are ok as we'll clearly be able to see the changes that happen (hopefully none 馃 ) which I think could be missed with the current approach.