Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed custom-select missing in select fields that have use_custom_con… #1116

Conversation

cpina
Copy link
Member

@cpina cpina commented Feb 20, 2021

…trol and prepended/appended text ((#1111)

closing #1111

@codecov-io
Copy link

codecov-io commented Feb 20, 2021

Codecov Report

Merging #1116 (fd49323) into master (8b3b824) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1116   +/-   ##
=======================================
  Coverage   97.22%   97.23%           
=======================================
  Files          24       24           
  Lines        2811     2820    +9     
  Branches      244      244           
=======================================
+ Hits         2733     2742    +9     
  Misses         38       38           
  Partials       40       40           
Flag Coverage Δ
unittests 97.16% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crispy_forms/tests/test_layout_objects.py 97.99% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b3b824...fd49323. Read the comment docs.

Copy link
Member

@smithdc1 smithdc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@smithdc1 smithdc1 merged commit 80f9d53 into django-crispy-forms:master Feb 20, 2021
@smithdc1 smithdc1 added this to the Next Release milestone Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants