Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from django.utils.six to six #44

Merged
merged 1 commit into from Feb 25, 2019
Merged

Migrate from django.utils.six to six #44

merged 1 commit into from Feb 25, 2019

Conversation

aleksihakli
Copy link
Contributor

@aleksihakli
Migrate from django.utils.six to six
b3f13bc 
Django #27753 has dropped six support

Signed-off-by: Aleksi Häkli <aleksi.hakli@iki.fi>
carltongibson
carltongibson reviewed Feb 24, 2019
View reviewed changes
Copy link
Contributor

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right... I guess it's time to think about version support then.
(i.e. Shouldn't we just go Python 3 only, and bump the version number?)

@carltongibson
Copy link
Contributor

Hey @diox @karyon — This has bearing on compressor too. For me, dropping Python 2 is timely/fine, but there should be some coordination I guess...

@diox
Copy link
Member

diox commented Feb 24, 2019

I wouldn't drop Python 2 / Django 1.11 until both are EOL. We can drop Django < 1.11 though.

@aleksihakli
Copy link
Contributor Author

aleksihakli commented Feb 24, 2019 •
edited

We have dropped Python 2.x support in some places where the maintenance of Python 2.x code has made the code bases more difficult to develop. Here the support is already baked in and the project is very stable, though. IMO supporting Python 2.7 until the EOL is a nice thing to do unless it isn't a too big hassle. In this specific case it only requires adding the six dependency and changing one import.

Our other package depends on django-appconf and requires it for testing against Django master, but at this moment the tests fail due to the missing six dependency.

Cutting a new release that supports upstream Django would be awesome.

Looking at the download (30d) stats, quite a few people still use Python 2.7 with django-appconf:

https://pypistats.org/packages/django-appconf

image

aleksihakli added a commit to jazzband/django-axes that referenced this pull request Feb 24, 2019
@aleksihakli
Add six imports for Django master compatibility
f2ebe08 
Implement forwards compatibility for missing
django.utils.six package imports on Django 2.2

Relates to django-compressor/django-appconf#44
and can be removed after django-appconf
has received a new release which deprecates
the use of the integrated Django six library

Signed-off-by: Aleksi Häkli <aleksi.hakli@iki.fi>
aleksihakli added a commit to jazzband/django-axes that referenced this pull request Feb 24, 2019
@aleksihakli
Add six imports for Django master compatibility
d4c2603 
Implement forwards compatibility for missing
django.utils.six package imports on Django 2.2

Relates to django-compressor/django-appconf#44
and can be removed after django-appconf
has received a new release which deprecates
the use of the integrated Django six library

Signed-off-by: Aleksi Häkli <aleksi.hakli@iki.fi>
carltongibson
carltongibson approved these changes Feb 25, 2019
View reviewed changes
Copy link
Contributor

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, all makes sense. Thanks both.

Let's have this. I'll roll a new release (for Python 3.7 folks) this week.

@carltongibson carltongibson merged commit 207c1b2 into django-compressor:develop Feb 25, 2019
simanto604newscred pushed a commit to simanto604newscred/django-axes that referenced this pull request Jul 31, 2019
@aleksihakli @simanto604newscred
Add six imports for Django master compatibility
9b1ba92 
Implement forwards compatibility for missing
django.utils.six package imports on Django 2.2

Relates to django-compressor/django-appconf#44
and can be removed after django-appconf
has received a new release which deprecates
the use of the integrated Django six library

Signed-off-by: Aleksi Häkli <aleksi.hakli@iki.fi>
simanto604newscred pushed a commit to simanto604newscred/django-axes that referenced this pull request Jul 31, 2019
@aleksihakli @simanto604newscred
Add six imports for Django master compatibility
70b58e9 
Implement forwards compatibility for missing
django.utils.six package imports on Django 2.2

Relates to django-compressor/django-appconf#44
and can be removed after django-appconf
has received a new release which deprecates
the use of the integrated Django six library

Signed-off-by: Aleksi Häkli <aleksi.hakli@iki.fi>
wannacfuture added a commit to wannacfuture/Tuto_Django that referenced this pull request Jun 1, 2023
@wannacfuture
Add six imports for Django master compatibility
642175f 
Implement forwards compatibility for missing
django.utils.six package imports on Django 2.2

Relates to django-compressor/django-appconf#44
and can be removed after django-appconf
has received a new release which deprecates
the use of the integrated Django six library

Signed-off-by: Aleksi Häkli <aleksi.hakli@iki.fi>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carltongibson carltongibson carltongibson approved these changes

@diox diox Awaiting requested review from diox

@karyon karyon Awaiting requested review from karyon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aleksihakli @carltongibson @diox